Create ConnIface interface and generate mock with mockgen #1369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Created the ConnIface interface aggregating all public methods of *Conn. - Generated a mock implementation for ConnIface using mockgen for easier testing.
cpeliciari
force-pushed
the
feat/mock
branch
from
d4e9dc4 to
a7f8e2c
Compare
|
We prefer to test against an actual Kafka implementation. It's less code to maintain and gives us more reassurance on the accuracy. Thank you for the suggestion though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took a look at #656 and became curious as to why we don’t simply ship a generic mock generated with mockgen. In the future, if the community feels it’s necessary, we can improve this mock. It’s also very important to note that we already have a Fake for the library, which helps developers create their unit tests. If you don’t see the need for this PR, feel free to close this was just a suggestion for a mock.
Changes: